This repository was archived by the owner on Feb 24, 2025. It is now read-only.
Simplify connecting sync accounts when two exist #3747
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graeme
changed the title
|
amddg44
approved these changes
Dec 19, 2024
amddg44
approved these changes
Dec 19, 2024
| @@ -406,6 +402,14 @@ extension SyncSettingsViewController: ScanOrPasteCodeViewModelDelegate { | |||
| return false | |||
| } | |||
|
|
|||
| func handleTwoSyncAccountsFoundDuringRecovery(_ recoveryKey: SyncCode.RecoveryKey) async { | |||
There was a problem hiding this comment.
Just a minor nit, I think this can be made private?
|
This PR has been inactive for more than 7 days and will be automatically closed 7 days from now. |
|
This PR has been closed after 14 days of inactivity. Feel free to reopen it if you plan to continue working on it or have further discussions. |
14 tasks
graeme
added a commit
that referenced
this pull request
Jan 27, 2025
Task/Issue URL: https://app.asana.com/0/72649045549333/1208944782348823/f Description: Reopened #3747 Around 600 daily Sync users try to connect a Synced device with another Sync Backup, which is not possible, and we show them an error indicating they should stop syncing first and try again. Simplify the steps by: Automatically Switch Sync for users with no other devices connected. (This is the most common scenario) - Ask, and allow them to continue switching sync for users with more devices connected. Steps to test this PR: https://app.asana.com/0/0/1208993297756834/f also confirm that pixels are sent: https://app.asana.com/0/1142021229838617/1208928557675008/f **Definition of Done (Internal Only)**: * [x] Does this PR satisfy our [Definition of Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)? **Copy Testing**: * [ ] Use of correct apostrophes in new copy, ie `’` rather than `'` **Orientation Testing**: * [ ] Portrait * [ ] Landscape **Device Testing**: * [ ] iPhone SE (1st Gen) * [ ] iPhone 8 * [ ] iPhone X * [ ] iPhone 14 Pro * [ ] iPad **OS Testing**: * [ ] iOS 15 * [ ] iOS 16 * [ ] iOS 17 **Theme Testing**: * [ ] Light theme * [ ] Dark theme --- ###### Internal references: [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) --------- Co-authored-by: Anya Mallon <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1208944782348823/f
Description:
Around 600 daily Sync users try to connect a Synced device with another Sync Backup, which is not possible, and we show them an error indicating they should stop syncing first and try again.
Simplify the steps by:
Automatically Switch Sync for users with no other devices connected. (This is the most common scenario) -
Ask, and allow them to continue switching sync for users with more devices connected.
Steps to test this PR:
https://app.asana.com/0/0/1208993297756834/f
also confirm that pixels are sent:
https://app.asana.com/0/1142021229838617/1208928557675008/f
Definition of Done (Internal Only):
Copy Testing:
’rather than'Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template